[GitHub] drill pull request #1033: DRILL-5952: Implement "CREATE TABLE IF NOT EXISTS"

[arina-ielchiieva]

Github user arina-ielchiieva commented on a diff in the pull request:

    https://github.com/apache/drill/pull/1033#discussion_r152583194
  
    --- Diff: 
exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/handlers/ViewHandler.java
 ---
    @@ -78,47 +78,58 @@ public PhysicalPlan getPlan(SqlNode sqlNode) throws 
ValidationException, RelConv
           final View view = new View(newViewName, viewSql, 
newViewRelNode.getRowType(),
               SchemaUtilites.getSchemaPathAsList(defaultSchema));
     
    -      validateViewCreationPossibility(drillSchema, createView, context);
    +      final String schemaPath = drillSchema.getFullSchemaName();
    --- End diff --
    
    It's a good practice in Java to factor out large code pieces into separate 
methods. I did this before in this class but your changes incorporated all 
logic back... Maybe there is a way to keep this logic separately here and in 
CreateTableHandler.class?


---