[GitHub] drill pull request #1033: DRILL-5952: Implement "CREATE TABLE IF NOT EXISTS"

[prasadns14]

Github user prasadns14 commented on a diff in the pull request:

    https://github.com/apache/drill/pull/1033#discussion_r152901257
  
    --- Diff: exec/java-exec/src/main/codegen/includes/parserImpls.ftl ---
    @@ -172,26 +172,34 @@ SqlNodeList ParseRequiredFieldList(String relType) :
     
     /**
      * Parses a create view or replace existing view statement.
    - *   CREATE [OR REPLACE] VIEW view_name [ (field1, field2 ...) ] AS 
select_statement
    + *   CREATE { [OR REPLACE] VIEW | VIEW [IF NOT EXISTS] | VIEW } view_name 
[ (field1, field2 ...) ] AS select_statement
      */
     SqlNode SqlCreateOrReplaceView() :
     {
         SqlParserPos pos;
    -    boolean replaceView = false;
         SqlIdentifier viewName;
         SqlNode query;
         SqlNodeList fieldList;
    +    String createViewType = "0";
    --- End diff --
    
    SqlLiteral doesn't support creating enum objects. So, I am forced to use 
string in parserImpls.ftl but I have now defined an enum in SqlCreateView.class


---