Github user laurentgo commented on a diff in the pull request:

    https://github.com/apache/drill/pull/1055#discussion_r154150476
  
    --- Diff: 
exec/java-exec/src/main/java/org/apache/drill/exec/testing/ExecutionControlsInjector.java
 ---
    @@ -81,8 +83,20 @@ public void injectPause(final ExecutionControls 
executionControls, final String
           executionControls.lookupPauseInjection(this, desc);
     
         if (pauseInjection != null) {
    -      logger.debug("Pausing at {}", desc);
    -      pauseInjection.pause();
    +      long pauseDuration = pauseInjection.getMsPause();
    +      if ( pauseDuration > 0L) {
    --- End diff --
    
    maybe nitpicky but I would use -1 (or any negative value) to distinguish 
between timed-bounded pause or not (since 0 is a valid wait time for 
CountDownLatch)


---

Reply via email to