Github user kkhatua commented on a diff in the pull request:
https://github.com/apache/drill/pull/1055#discussion_r154246723
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/testing/ExecutionControlsInjector.java
---
@@ -81,8 +83,20 @@ public void injectPause(final ExecutionControls
executionControls, final String
executionControls.lookupPauseInjection(this, desc);
if (pauseInjection != null) {
- logger.debug("Pausing at {}", desc);
- pauseInjection.pause();
+ long pauseDuration = pauseInjection.getMsPause();
+ if ( pauseDuration > 0L) {
+ logger.debug("Pausing at {} for {} sec", desc,
TimeUnit.MILLISECONDS.toSeconds(pauseDuration) );
+ } else {
+ logger.debug("Pausing at {}", desc);
+ }
+ try {
+ pauseInjection.pause();
+ } catch (InterruptedException e) {
+ //Unpause if this is a timed pause, because an explicit unpause is
not called
+ if (pauseDuration > 0L) {
--- End diff --
Just following convention of 'unpausing' explicitly, rather than implicitly
within the `pause()` for a limited-duration pause.
---
