Github user Ben-Zvi commented on a diff in the pull request:
https://github.com/apache/drill/pull/1057#discussion_r157646636
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/svremover/CopierTemplate4.java
---
@@ -54,17 +52,33 @@ public int copyRecords(int index, int recordCount)
throws SchemaChangeException
}
}
- int outgoingPosition = 0;
- for(int svIndex = index; svIndex < index + recordCount; svIndex++,
outgoingPosition++){
+ return insertRecords(0, index, recordCount);
+ }
+
+ @Override
+ public int appendRecord(int index) throws SchemaChangeException {
+ return appendRecords(index, 1);
+ }
--- End diff --
Minor performance comment: If *appendRecord()* is to be used heavily, then
the overhead of calling the for() loop (in insertRecords() ) many times for
only a size of 1 may be significant.
---
