Github user Ben-Zvi commented on a diff in the pull request:
https://github.com/apache/drill/pull/1057#discussion_r157616077
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/svremover/Copier.java
---
@@ -19,13 +19,15 @@
import org.apache.drill.exec.compile.TemplateClassDefinition;
import org.apache.drill.exec.exception.SchemaChangeException;
-import org.apache.drill.exec.ops.FragmentContext;
import org.apache.drill.exec.record.RecordBatch;
+import org.apache.drill.exec.record.VectorContainer;
public interface Copier {
- public static TemplateClassDefinition<Copier> TEMPLATE_DEFINITION2 = new
TemplateClassDefinition<Copier>(Copier.class, CopierTemplate2.class);
- public static TemplateClassDefinition<Copier> TEMPLATE_DEFINITION4 = new
TemplateClassDefinition<Copier>(Copier.class, CopierTemplate4.class);
+ TemplateClassDefinition<Copier> TEMPLATE_DEFINITION2 = new
TemplateClassDefinition<Copier>(Copier.class, CopierTemplate2.class);
+ TemplateClassDefinition<Copier> TEMPLATE_DEFINITION4 = new
TemplateClassDefinition<Copier>(Copier.class, CopierTemplate4.class);
--- End diff --
Just for cleanliness, should do the same (remove all the
public/static/abstract/final ) in **filter/Filterer.java** as well !
---
