Github user parthchandra commented on a diff in the pull request:

    https://github.com/apache/drill/pull/1049#discussion_r159003539
  
    --- Diff: exec/vector/src/main/codegen/templates/FixedValueVectors.java ---
    @@ -394,9 +394,11 @@ public void get(int index, 
Nullable${minor.class}Holder holder){
           final int offsetIndex = index * VALUE_WIDTH;
           final int months  = data.getInt(offsetIndex);
           final int days    = data.getInt(offsetIndex + ${minor.daysOffset});
    -      final int millis = data.getInt(offsetIndex + 
${minor.millisecondsOffset});
    +      int millis = data.getInt(offsetIndex + 8);
    --- End diff --
    
    Hmm. The only reason for this change was to overcome a Joda problem that 
caused the unit tests to fail. I fixed the unit tests and undid the change. 


---

Reply via email to