Github user parthchandra commented on a diff in the pull request:

    https://github.com/apache/drill/pull/1049#discussion_r158985937
  
    --- Diff: 
exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/columnreaders/ColumnReaderFactory.java
 ---
    @@ -138,6 +138,8 @@
                     return new 
ParquetFixedWidthDictionaryReaders.DictionaryBigIntReader(recordReader, 
allocateSize, descriptor, columnChunkMetaData, fixedLength, (BigIntVector) v, 
schemaElement);
    --- End diff --
    
    Hmm. Looks like I missed INT_32 here. Added it but I cannot seem to force 
the test generator to generate dictionary encoded values for the logical int 
types. I'll make a note to enhance it later. Note that the DATE type is 
(apparently) handled by the code on line 101.


---

Reply via email to