[GitHub] drill pull request #570: DRILL-4834 decimal implementation is vulnerable to ...

[vvysotskyi]

Github user vvysotskyi commented on a diff in the pull request:

    https://github.com/apache/drill/pull/570#discussion_r160480509
  
    --- Diff: exec/java-exec/src/main/codegen/templates/SqlAccessors.java ---
    @@ -127,6 +127,25 @@ public String getString(int index) {
         }
           <#break>
     
    +    <#case "VarDecimal">
    +
    +    @Override
    +    public String getString(int index){
    +<#if mode=="Nullable">
    +        if(ac.isNull(index)){
    +          return null;
    +        }
    +</#if>
    +        try {
    --- End diff --
    
    I don't see the necessity of try catch there. Could you please explain?


---