[GitHub] drill pull request #570: DRILL-4834 decimal implementation is vulnerable to ...

[daveoshinsky]

Github user daveoshinsky commented on a diff in the pull request:

    https://github.com/apache/drill/pull/570#discussion_r160776544
  
    --- Diff: 
exec/java-exec/src/main/codegen/templates/Decimal/DecimalAggrTypeFunctions2.java
 ---
    @@ -108,9 +108,12 @@ public void output() {
         out.buffer = buffer;
         out.start  = 0;
         out.scale = outputScale.value;
    -    out.precision = 38;
         java.math.BigDecimal average = 
((java.math.BigDecimal)(value.obj)).divide(java.math.BigDecimal.valueOf(count.value,
 0), out.scale, java.math.BigDecimal.ROUND_HALF_UP);
    +<#if type.inputType.contains("VarDecimal")>
    --- End diff --
    
    Yes, I will try "<#if !type.inputType.contains("VarDecimal")>"


---