Github user paul-rogers commented on a diff in the pull request:

    https://github.com/apache/drill/pull/1082#discussion_r160539584
  
    --- Diff: distribution/src/resources/drill-config.sh ---
    @@ -180,18 +251,46 @@ else
       fi
     fi
     
    -# Default memory settings if none provided by the environment or
    +# Checking if being executed in context of Drillbit and not SQLLine
    +if [ "$DRILLBIT_CONTEXT" == "1" ]; then 
    +  # *-auto.sh allows for distrib/user specific checks to be done
    +  distribAuto="$DRILL_CONF_DIR/distrib-auto.sh"
    +  if [ ! -r "$distribAuto" ]; then 
distribAuto="$DRILL_HOME/conf/distrib-auto.sh"; fi
    +  if [ ! -r "$distribAuto" ]; then distribAuto=""; fi
    +  drillAuto="$DRILL_CONF_DIR/drill-auto.sh"
    +  if [ ! -r "$drillAuto" ]; then 
drillAuto="$DRILL_HOME/conf/drill-auto.sh"; fi
    --- End diff --
    
    This part is just a bit tricky. Drill- and distribution- specific files do, 
in fact, reside in `$DRILL_HOME/conf`. But, user files reside in a number of 
places. So, please use:
    
    - `$DRILL_HOME/conf` for `distrib-auto.sh`
    - `$DRILL_CONF_DIR` for user-supplied files (such as `drill-auto.sh`)


---

Reply via email to