Github user paul-rogers commented on a diff in the pull request:

    https://github.com/apache/drill/pull/1082#discussion_r164324543
  
    --- Diff: distribution/src/assemble/bin.xml ---
    @@ -345,6 +345,21 @@
           <fileMode>0755</fileMode>
           <outputDirectory>conf</outputDirectory>
         </file>
    +    <file>
    +      <source>src/resources/auto-setup.sh</source>
    +      <fileMode>0755</fileMode>
    +      <outputDirectory>bin</outputDirectory>
    +    </file>
    +    <file>
    +      <source>src/resources/drill-setup.sh</source>
    +      <fileMode>0755</fileMode>
    +      <outputDirectory>conf</outputDirectory>
    +    </file>
    +    <file>
    +      <source>src/resources/distrib-setup.sh</source>
    --- End diff --
    
    There should be no "distrib" files in Drill. The scripts should check if 
they exist, and if not (the default), just ignore the file. Distributions add 
their own files. Having no default file makes clear that these are not 
Apache-provided files.


---

Reply via email to