Github user vvysotskyi commented on a diff in the pull request:
https://github.com/apache/drill/pull/570#discussion_r160980556
--- Diff: exec/vector/src/main/codegen/templates/VariableLengthVectors.java
---
@@ -539,7 +553,12 @@ public void setValueLengthSafe(int index, int length) {
}
- public void setSafe(int index, int start, int end, DrillBuf buffer){
+<#if type.minor == "VarDecimal">
--- End diff --
Sorry, perhaps I made mistake, yes, it looks OK.
But do we need to pass `scale` for `VarDecimal` even if we don't use it in
this method?
I suppose should be made a change in `ComplexWriters.java` to avoid the
usage of this method with the additional argument.
---
