[GitHub] drill pull request #570: DRILL-4834 decimal implementation is vulnerable to ...

[vvysotskyi]

Github user vvysotskyi commented on a diff in the pull request:

    https://github.com/apache/drill/pull/570#discussion_r161015751
  
    --- Diff: exec/vector/src/main/codegen/templates/VariableLengthVectors.java 
---
    @@ -418,6 +422,16 @@ public void get(int index, 
Nullable${minor.class}Holder holder){
     
     
         <#switch minor.class>
    +    <#case "VarDecimal">
    +    @Override
    +    public ${friendlyType} getObject(int index) {
    +      byte[] b = get(index);
    +      BigInteger bi = new BigInteger(b);
    +      BigDecimal bd = new BigDecimal(bi, getField().getScale());
    +      //System.out.println("VarDecimal getObject " + index + " scale " + 
getField().getScale() + " len " + b.length + " bd " + bd);
    --- End diff --
    
    Please remove this comment


---