Github user Ben-Zvi commented on a diff in the pull request:
https://github.com/apache/drill/pull/1057#discussion_r161950855
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/svremover/AbstractSV4Copier.java
---
@@ -17,32 +17,30 @@
*/
package org.apache.drill.exec.physical.impl.svremover;
-import javax.inject.Named;
-
import org.apache.drill.common.types.TypeProtos.MajorType;
import org.apache.drill.common.types.Types;
import org.apache.drill.exec.exception.SchemaChangeException;
-import org.apache.drill.exec.ops.FragmentContext;
import org.apache.drill.exec.record.RecordBatch;
+import org.apache.drill.exec.record.VectorContainer;
import org.apache.drill.exec.record.VectorWrapper;
import org.apache.drill.exec.record.selection.SelectionVector4;
import org.apache.drill.exec.vector.AllocationHelper;
+import org.apache.drill.exec.vector.ValueVector;
-public abstract class CopierTemplate4 implements Copier{
- static final org.slf4j.Logger logger =
org.slf4j.LoggerFactory.getLogger(CopierTemplate4.class);
+public abstract class AbstractSV4Copier implements Copier {
--- End diff --
The code for AbstractSV4Copier is nearly identical to the code of
AbstractSV2Copier; I wonder if we could have combined the two somehow (like a
super class ??)
---
