Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/1072#discussion_r162517870
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/exec/expr/fn/impl/TestSqlPatterns.java
---
@@ -446,6 +446,61 @@ public void testSqlPatternComplex() {
assertEquals(1, sqlPatternComplex.match(0, byteBuffer.limit(),
drillBuf)); // should match
}
+ @Test
+ public void testSqlPatternContainsMUltipleMatchers() {
--- End diff --
If tests exist, and you have verified that each of the lengths is, in fact,
tested by those tests, then I'm fine with adding a comment identifying the
cases and where to find the existing tests. The point is to make sure all
variations are fully tested -- one way or another.
---
