Github user chunhui-shi commented on a diff in the pull request:

    https://github.com/apache/drill/pull/1096#discussion_r163048747
  
    --- Diff: 
exec/java-exec/src/main/java/org/apache/drill/exec/planner/PlannerPhase.java ---
    @@ -341,7 +346,7 @@ static RuleSet getPruneScanRules(OptimizerRulesContext 
optimizerRulesContext) {
                 
ParquetPruneScanRule.getFilterOnProjectParquet(optimizerRulesContext),
                 
ParquetPruneScanRule.getFilterOnScanParquet(optimizerRulesContext),
                 DrillPushLimitToScanRule.LIMIT_ON_SCAN,
    -            DrillPushLimitToScanRule.LIMIT_ON_PROJECT
    +            DrillPushLimitToScanRule.LIMIT_ON_PROJECT_SCAN
    --- End diff --
    
    Not sure if we still need "limit_on_project_scan". In theory, 
limit_on_project and limit_on_scan should already cover all the cases. Have you 
tested with "limit_on_project_scan" disabled?


---

Reply via email to