Github user chunhui-shi commented on a diff in the pull request:

    https://github.com/apache/drill/pull/1096#discussion_r164585670
  
    --- Diff: 
exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/DrillPushLimitToScanRule.java
 ---
    @@ -121,4 +132,50 @@ protected void doOnMatch(RelOptRuleCall call, 
DrillLimitRel limitRel, DrillScanR
         }
     
       }
    +
    +  private static boolean isProjectFlatten(RelNode project) {
    --- End diff --
    
    I think it might be more general to name the functions to schemaUnknown(for 
conert_fromJson), rowCountUnknown(for flatten), so if in future we have some 
other functions fall in these two categories, we could easily add these 
functions to the categories. What do you think?


---

Reply via email to