Github user amansinha100 commented on a diff in the pull request: https://github.com/apache/drill/pull/1117#discussion_r167441911 --- Diff: contrib/storage-hive/core/src/test/java/org/apache/drill/exec/TestHashJoinOrdering.java --- @@ -0,0 +1,63 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.drill.exec; + +import org.apache.drill.categories.HiveStorageTest; +import org.apache.drill.categories.SlowTest; +import org.apache.drill.exec.hive.HiveTestBase; +import org.apache.drill.exec.planner.physical.PlannerSettings; +import org.apache.drill.test.QueryTestUtil; +import org.junit.AfterClass; +import org.junit.Assert; +import org.junit.BeforeClass; +import org.junit.Test; +import org.junit.experimental.categories.Category; + +@Category({SlowTest.class, HiveStorageTest.class}) +public class TestHashJoinOrdering extends HiveTestBase { --- End diff -- I am wondering why a separate HashJoinOrdering test is needed for Hive. The Drill join planner is not doing something specific for Hive tables. If we have a Hive test, why not for other storage plugins such as HBase etc but since the proposed fix removes Collation property for any input stream of a HashJoin, it should not matter where that input originated from.
---