Github user paul-rogers commented on a diff in the pull request:

    https://github.com/apache/drill/pull/1120#discussion_r167743599
  
    --- Diff: 
exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/xsort/TestSortSpillWithException.java
 ---
    @@ -59,6 +59,7 @@ public static void setup() throws Exception {
         ClusterFixtureBuilder builder = ClusterFixture.builder(dirTestWatcher)
             .configProperty(ExecConstants.EXTERNAL_SORT_SPILL_THRESHOLD, 1) // 
Unmanaged
             .configProperty(ExecConstants.EXTERNAL_SORT_SPILL_GROUP_SIZE, 1) 
// Unmanaged
    +        .configProperty(ExecConstants.EXTERNAL_SORT_MAX_MEMORY, 10 * 1024 
* 1024) //use less memory for sorting.
    --- End diff --
    
    The need to set this property suggest something is wrong with the next one. 
We set max query memory per node to 60 MB. Then, the 
`MemoryAllocationUtilitites` is supposed to divide that up. If you have to 
override that, then something is amiss. We should track down that problem.
    
    A good place to start is to turn on logging for this test (using the log 
fixture.) The sort will dump its configured memory. If it is still 2 GB, then 
debug the memory allocation utilities.
    
    Perhaps it is as simple as using the wrong option below...


---

Reply via email to