Github user HanumathRao commented on a diff in the pull request:

    https://github.com/apache/drill/pull/1120#discussion_r167760816
  
    --- Diff: 
exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/xsort/TestSortSpillWithException.java
 ---
    @@ -59,6 +59,7 @@ public static void setup() throws Exception {
         ClusterFixtureBuilder builder = ClusterFixture.builder(dirTestWatcher)
             .configProperty(ExecConstants.EXTERNAL_SORT_SPILL_THRESHOLD, 1) // 
Unmanaged
             .configProperty(ExecConstants.EXTERNAL_SORT_SPILL_GROUP_SIZE, 1) 
// Unmanaged
    +        .configProperty(ExecConstants.EXTERNAL_SORT_MAX_MEMORY, 10 * 1024 
* 1024) //use less memory for sorting.
    --- End diff --
    
    @paul-rogers  Thank you for the review. In this case, the memory configured 
per node is 60MB and the maxParallelization is set to 1. The min buffered op 
memory is 40MB by default.
       * Minimum memory allocated to each buffered operator instance.
       * <p/>
       * DEFAULT: 40 MB
    
    In my branch (which has got other changes also) 40MB is being correctly set 
for the sort to use. However, this memory is sufficient for the concerned query 
to not to spill the data to disk and it is executing fine without triggering 
the exception mechanism.
    
    I tried to set max_per_node memory to 10MB but even after setting the 
memorycomputation utilities will only set sort memory to 40MB. Hence it is of 
no use in this case.
    
    Therefore, I have used this option so that this test will consistently 
pass. Please let me know if I am missing anything here.


---

Reply via email to