Github user arina-ielchiieva commented on a diff in the pull request:

    https://github.com/apache/drill/pull/1138#discussion_r172599233
  
    --- Diff: 
exec/java-exec/src/main/java/org/apache/drill/exec/store/ColumnExplorer.java ---
    @@ -78,6 +79,23 @@ public ColumnExplorer(OptionManager optionManager, 
List<SchemaPath> columns) {
         return map;
       }
     
    +  /**
    +   * Returns list with implicit column names taken from specified {@link 
SchemaConfig}.
    +   *
    +   * @param schemaConfig the source of session options values.
    +   * @return list with implicit column names.
    +   */
    +  public static List<String> getImplicitColumns(SchemaConfig schemaConfig) 
{
    --- End diff --
    
    Please rename
    1. `getImplicitColumns` -> `getImplicitColumnsNames`
    2. `getPartitions` -> `getPartitionColumnNames`


---

Reply via email to