Github user arina-ielchiieva commented on a diff in the pull request:

    https://github.com/apache/drill/pull/1138#discussion_r172606583
  
    --- Diff: 
exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/SqlConverter.java
 ---
    @@ -277,6 +279,25 @@ public String deriveAlias(
           return SqlValidatorUtil.getAlias(node, ordinal);
         }
     
    +    /**
    +     * Checks that specified expression is not implicit column and
    +     * adds is to a select list, ensuring that its alias does not
    +     * clash with any existing expressions on the list.
    +     */
    +    @Override
    +    protected void addToSelectList(
    --- End diff --
    
    Could you please add comment explaining when this method is used and how 
know when to add columns to Avro table and not for Dynamic?


---

Reply via email to