Github user vrozov commented on a diff in the pull request:

    https://github.com/apache/drill/pull/1145#discussion_r172718426
  
    --- Diff: exec/rpc/src/main/java/org/apache/drill/exec/rpc/BasicClient.java 
---
    @@ -69,6 +74,11 @@
       private final IdlePingHandler pingHandler;
       private ConnectionMultiListener.SSLHandshakeListener 
sslHandshakeListener = null;
     
    +  // Authentication related parameters
    +  protected volatile List<String> serverAuthMechanisms = null;
    --- End diff --
    
    Is `volatile` necessary? Consider making all variables private and 
providing `setAuthRequired(List<String> authMechanisms)`.


---

Reply via email to