Github user sohami commented on a diff in the pull request: https://github.com/apache/drill/pull/1145#discussion_r173041288 --- Diff: exec/rpc/src/main/java/org/apache/drill/exec/rpc/BasicClient.java --- @@ -182,6 +196,66 @@ public boolean isActive() { protected abstract void validateHandshake(HR validateHandshake) throws RpcException; + /** + * Creates various instances needed to start the SASL handshake. This is called from + * {@link BasicClient#validateHandshake(MessageLite)} if authentication is required from server side. + * @param connectionListener + * @throws RpcException + */ + protected abstract void prepareSaslHandshake(final RpcConnectionHandler<CC> connectionListener) throws RpcException; --- End diff -- removed from here and `startSaslHandshake`
---