0 (non-binding)

- verified release signature and hash
- verified build "mvn -Dmaven.repo.local=/tmp/.m2/repository/ install -DskipTests"
- verified NOTICE, LICENSE and README.md
- checked DEPENDENCIES

issues noted (in order of severity)
- the source distribution contains binary jar files under exec/java-exec/src/test/resources/jars
- dependency licensed under GNU LGPL
- copyright year range in NOTICE needs to be updated
- release is signed with the signature that is valid till 2018-10-09

Thank you,

Vlad

On 3/15/18 15:31, Sorabh Hamirwasia wrote:
   *   Downloaded binary tarball from [2] and deployed 2 node cluster
   *   Ran some basic queries using sqlline and Web UI with and without 
security enabled
   *   Verified user to bit secure connections using Plain/Kerberos
   *   Verified bit to bit secure connections using Kerberos.
      *   During testing I found an issue that local control message is still 
creating a connection, but is not related to this release. The issue is a regression 
because of state introduced in Drillbit endpoint as part of shutdown feature in 1.12. 
I have opened DRILL-6255<https://issues.apache.org/jira/browse/DRILL-6255> for 
this issue with details in it.
   *   Verified SPNEGO and FORM authentication for Web UI
   *   Ran and verify queries against sys.connections table
   *   Built C++ client on linux box using the source tarball from [2] and ran 
queries to secure and unsecure Drillbit


LGTM +1 (non-binding)


Thanks,
Sorabh

________________________________
From: Vitalii Diravka <[email protected]>
Sent: Thursday, March 15, 2018 11:12 AM
To: [email protected]
Subject: Re: [VOTE] Apache Drill release 1.13.0 - RC0

* Downloaded sources tarball from [2].
Ran drill in embedded mode on local debian machine. Ran tpch queries with
joins, group by, order by, limit, order by with limit statements.
Looked through logs - looks good.
* Build drill for [4] with MapR profile. Ran driillbit in distributed mode
on centos VM with MapR core. Ran queries for Hive 1.2, ran queries for Hive
2.1 (transactional and non-transactional tables). Connected to this
drillbit from remote machine via JDBC with java programm and with SQuirrel
using different drivers (prebuild "drill-jdbc-all-1.12.0.jar" from [2]
tarball, the driver after build [4] sources with default and MapR profiles
too) and ran a simple query. Ran the same with enabled custom
authentication (jdbc driver which is build with MapR profile works good
too).
In the process of testing jdbc connection I found the issue - DRILL-6251.
It is a regression. I have described the case in Jira. But I suppose isn't
critical for current Drill release.
* All unit test were passed for [4]. Total time on my machine was: 42:10 min

+1 (non-binding)

Kind regards
Vitalii

On Thu, Mar 15, 2018 at 4:49 PM, Vova Vysotskyi <[email protected]> wrote:

- Downloaded source tar at [2], ran unit tests and all tests are passed.
- Downloaded built tar at [2], submitted several TPCH queries from UI,
checked that profiles are displayed correctly.
- Connected from SQuirrel, ran several queries; ran queries from a java
application, no issues were found.

+1 (non-binding)


2018-03-15 13:19 GMT+02:00 Arina Yelchiyeva <[email protected]>:

  - Built from the source [4] on Linux, run unit test.
- Downloaded the binary tarball [2], untarred and ran Drill in embedded
mode on Windows.
- Ran sample queries, checked system tables, profiles on Web UI, also
logs
and index page.
- Created persistent and temporary tables, loaded custom UDFs.

+1 (binding)

Kind regards
Arina

On Thu, Mar 15, 2018 at 1:39 AM, Aman Sinha <[email protected]>
wrote:
- Downloaded the source tarball from [2] on my Linux VM, built and ran
the
unit tests successfully
- Downloaded the binary tarball onto my Macbook, untarred and ran Drill
in
embedded mode
- Ran several queries  against a TPC-DS SF1 data set, including CTAS
statements with PARTITION BY and ran a few partition pruning queries
- Tested query cancellation by cancelling a query that was taking long
time
due to expanding join
- Examined the run-time query profiles of these queries with and
without
parallelism.
- Checked the maven artifacts on [3].

  - Found one reference to JDK 7 : README.md says 'JDK 7' in the
Prerequisites.  Ideally, this should be changed to JDK 8

Overall, LGTM  +1 (binding)


On Tue, Mar 13, 2018 at 3:58 AM, Parth Chandra <[email protected]>
wrote:
Hi all,

I'd like to propose the first release candidate (RC0) of Apache
Drill,
version 1.13.0.

The release candidate covers a total of 113 resolved JIRAs [1].
Thanks
to everyone
who contributed to this release.

The tarball artifacts are hosted at [2] and the maven artifacts are
hosted
at
[3].

This release candidate is based on commit
cac2882d5a9e22fbc251e4caf622fe30242ad557 located at [4].

Please download and try out the release.

The vote ends at 1:00 PM UTC (5:00 AM PDT, 2:00 PM EET, 5:30 PM IST),
Mar
16th, 2018

[ ] +1
[ ] +0
[ ] -1

Here's my vote: +1


[1 ]
https://urldefense.proofpoint.com/v2/url?u=https-3A__issues.apache.org_jira_secure_ReleaseNote.jspa-3F&d=DwIBaQ&c=cskdkSMqhcnjZxdQVpwTXg&r=gRpEl0WzXE3EMrwj0KFbZXGXRyadOthF2jlYxvhTlQg&m=KEiLBmU_AfF348bedn1JTJpJFT0anvMkA_8WeabKK7M&s=-ZI12ZJ6Rio7ezMHlrbba1pOC-KJU89YlG-HsaDr8Xg&e=
projectId=12313820&version=12342096

[2] 
https://urldefense.proofpoint.com/v2/url?u=http-3A__home.apache.org_-7Eparthc_drill_releases_1.13.0_rc0_&d=DwIBaQ&c=cskdkSMqhcnjZxdQVpwTXg&r=gRpEl0WzXE3EMrwj0KFbZXGXRyadOthF2jlYxvhTlQg&m=KEiLBmU_AfF348bedn1JTJpJFT0anvMkA_8WeabKK7M&s=u6H4h7BttJK2DUa68DxSBVwUvzgjlP4w6WvGoC0kNJM&e=

[3] 
https://urldefense.proofpoint.com/v2/url?u=https-3A__repository.apache.org_content_repositories_&d=DwIBaQ&c=cskdkSMqhcnjZxdQVpwTXg&r=gRpEl0WzXE3EMrwj0KFbZXGXRyadOthF2jlYxvhTlQg&m=KEiLBmU_AfF348bedn1JTJpJFT0anvMkA_8WeabKK7M&s=3LAbmx3QJrRcec1yAfvu9HCjcUdWpuudKXsPgMc4Mfw&e=
orgapachedrill-1046
[4] 
https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_parthchandra_drill_tree_drill-2D1.13.0&d=DwIBaQ&c=cskdkSMqhcnjZxdQVpwTXg&r=gRpEl0WzXE3EMrwj0KFbZXGXRyadOthF2jlYxvhTlQg&m=KEiLBmU_AfF348bedn1JTJpJFT0anvMkA_8WeabKK7M&s=rt5yHZyyn0QlGYZGvpzqkSYEc5cGe2LvDe1ZTNTkK20&e=



--
Kind regards,
Volodymyr Vysotskyi


Reply via email to