Github user vdiravka commented on a diff in the pull request:
https://github.com/apache/drill/pull/1166#discussion_r178070635
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/writer/TestParquetWriter.java
---
@@ -780,17 +783,42 @@ public void
testImpalaParquetBinaryAsVarBinary_DictChange() throws Exception {
Test the reading of a binary field as drill timestamp where data is in
dictionary _and_ non-dictionary encoded pages
*/
@Test
- @Ignore("relies on particular time zone, works for UTC")
public void testImpalaParquetBinaryAsTimeStamp_DictChange() throws
Exception {
try {
testBuilder()
.sqlQuery("select int96_ts from dfs.`parquet/int96_dict_change`
order by int96_ts")
.optionSettingQueriesForTestQuery(
"alter session set `%s` = true",
ExecConstants.PARQUET_READER_INT96_AS_TIMESTAMP)
.ordered()
-
.csvBaselineFile("testframework/testParquetReader/testInt96DictChange/q1.tsv")
- .baselineTypes(TypeProtos.MinorType.TIMESTAMP)
.baselineColumns("int96_ts")
+ .baselineValues(new DateTime(convertToLocalTimestamp("1970-01-01
00:00:01.000")))
--- End diff --
One baselineValue is enough. Please use `where` in the query.
---
