Github user vdiravka commented on a diff in the pull request:
https://github.com/apache/drill/pull/1166#discussion_r178009588
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/writer/TestParquetWriter.java
---
@@ -797,6 +797,24 @@ public void
testImpalaParquetBinaryAsTimeStamp_DictChange() throws Exception {
}
}
+ @Test
+ public void testSparkParquetBinaryAsTimeStamp_DictChange() throws
Exception {
+ try {
+ mockUtcDateTimeZone();
--- End diff --
I see that in `TestParquetWriter` only one parameter is used - `repeat`. I
think you can replace `Parameterized` running of this. test with simple
variable.
Other approach - you can write programmatically using of JMockit.
But I prefer not to use mocks if possible. So try to use
`convertToLocalTimestamp`. By using it you can enable also
`testHiveParquetTimestampAsInt96_basic` test and
`testImpalaParquetBinaryAsTimeStamp_DictChange` with removing redundant rows.
---
