Github user amansinha100 commented on a diff in the pull request:
https://github.com/apache/drill/pull/1226#discussion_r183091956
--- Diff: exec/java-exec/src/test/java/org/apache/drill/TestUnionAll.java
---
@@ -634,10 +634,14 @@ public void testFilterPushDownOverUnionAll() throws
Exception {
+ "order by n_regionkey";
// Validate the plan
- final String[] expectedPlan = {".*Filter.*\n" +
- ".*UnionAll.*\n" +
- ".*Scan.*columns=\\[`n_regionkey`\\].*\n" +
- ".*Scan.*columns=\\[`r_regionkey`\\].*"};
+ final String[] expectedPlan = {"Sort.*\n" +
--- End diff --
Apart from these tests, do we have any unit tests that produce empty
results once the filter is pushed on either side of the union-all ? I expect
that there could be some issues uncovered due to empty batch handling.
However, those issues could be treated as separate JIRA.
---
