Github user vdiravka commented on a diff in the pull request:

    https://github.com/apache/drill/pull/1226#discussion_r183763991
  
    --- Diff: 
exec/java-exec/src/main/java/org/apache/drill/exec/planner/PlannerPhase.java ---
    @@ -178,6 +178,12 @@ public RuleSet getRules(OptimizerRulesContext context, 
Collection<StoragePlugin>
               PlannerPhase.getPhysicalRules(context),
               getStorageRules(context, plugins, this));
         }
    +  },
    +
    +  PRE_LOGICAL_PLANNING("Planning with Hep planner only for rules, which 
are failed for Volcano planner") {
    --- End diff --
    
    You are right, it is necessary to add these rules to Drill's 
`staticRuleSet`, so then these setOpTranspose rules can cover more cases.
    
    When it will be added to Volcano Planner we can think, whether to remove 
`PlannerPhase.PRE_LOGICAL_PLANNING` or to leave it for more complete 
`directory_pruning` or think to move `PlannerPhase.DIRECTORY_PRUNING` to 
`staticRuleSet` for Volcano Planner too.


---

Reply via email to