Hi All, These are some PRs that were already +1'd by a committer but never merged. Most have conflicts, some don't even have conflicts. If there are any volunteers to take these across the finish line that would be great.
https://github.com/apache/drill/pull/292 https://github.com/apache/drill/pull/309 https://github.com/apache/drill/pull/437 https://github.com/apache/drill/pull/441 https://github.com/apache/drill/pull/455 https://github.com/apache/drill/pull/480 https://github.com/apache/drill/pull/652 There were also 7 really small documentation changes that I think we can merge and close. I will follow up with Bridget about those. Thanks, Tim ________________________________ From: Timothy Farkas <[email protected]> Sent: Thursday, May 31, 2018 6:05:15 PM To: [email protected] Subject: Re: [Discuss] Cleanup Old PRs Closed the first round of obsolete PRs. Went from 148 open to 125 open. I observed some other low hanging fruit that could be closed. Specifically there were some small PRs against gh-pages, half of which were already +1'd but never merged and the other half of which looked pretty reasonable to me but never reviewed. So my question is what is the proper process for merging changes into gh-pages? Paul to kickstart the process of pushing PRs over the line I'll compile a list of PRs that were +1'd but never merged. Perhaps we can get some committers to volunteer to update the old +1'd PRs and merge them. Thanks, Tim ________________________________ From: Paul Rogers <[email protected]> Sent: Thursday, May 31, 2018 4:53:24 PM To: [email protected] Subject: Re: [Discuss] Cleanup Old PRs +1 I just learned to ignore the ancient PRs; they were not adding much value. If a PR looks like it could be resurrected, we might consider 1) assigning a committer to help push it over the line, and 2) check back with submitter to see if they can update it. We tried the above a few times over the last couple of years and were able to finish a couple of otherwise-stale PRs. Thanks, - Paul On Thursday, May 31, 2018, 2:35:25 PM PDT, Timothy Farkas <[email protected]> wrote: Hi All, There are a lot of open PRs. I think it would be good to close some of them in order to identify the remaining PRs that require action to be taken. Specifically I was thinking of first closing obsolete PRs and then see how far that takes us. A PR could be considered obsolete if it is: * Changing code or documentation that no longer exists. * Adding documentation that is no longer correct. * Has a note already on the PR that it needs to be closed because another PR was opened. Any thoughts? Thanks, Tim
