Tim, It's too restrictive, unless something can be done to educate (outsider) PR authors like myself to "go against the grain" and keep asking. And asking. And asking. And asking. You get the picture? I did all that. And it was ignored. I assumed that people outside MapR aren't welcome to contribute, and/or there was little interest in making decimal work properly, and/or there was simply nobody available to review it (what I was most comfortable believing), and/or my emails smelled really bad (kidding on the last one 8-). I asked a few times, and asked again a few times a few months later, and nothing. What can you do to educate outsiders as to what they need to do to make sure a useful PR doesn't get flushed down the toilet? I spent days learning some amount of Drill internals and implementing VARDECIMAL (over 70 source files changed), and did it again months later to merge to then current master tip. All ignored for quite some time.
Thanks to Volodymyr Vysotskyi for ultimately grabbing the ball and running with it. That complex a change required an "insider" to bring it fully to fruition. But if the PR had been automatically flushed, I have my doubts as to whether the story would have ended the same way. Thanks, Dave Oshinsky ________________________________________ From: Timothy Farkas <[email protected]> Sent: Wednesday, June 6, 2018 7:07 PM To: [email protected] Subject: Re: [Vote] Cleaning Up Old PRs Good point Dave. With this automation and a stale period of 3 months, PRs would be closed after 3 months of inactivity. However, if you just post one comment asking a reviewer to review once every three months, it will stay alive indefinitely. Also if you don't want to do this you could request your PR to be marked as pending, and it would be exempt from the rule and never be closed automatically. The idea behind this automation is to distinguish PRs from contributors who are actively working on their PRs and contributors who open a PR but then never follow up. In open source, the latter happens often and it really overloads the system with PRs that will never be finished. Also having this automation with an explicit time limit incentivizes the contributor to make noise and comment on the PR to get a review. In my opinion this is exactly what we want, if your PR doesn't get reviewed you should make noise and spam us with messages until we make it happen. As long as you keep making noise, your PR won't be closed, and it helps keep us honest by doing timely reviews. What are your thoughts? Do you still feel this is too restrictive? Thanks, Tim ________________________________ From: Dave Oshinsky <[email protected]> Sent: Wednesday, June 6, 2018 3:50:15 PM To: [email protected] Subject: Re: [Vote] Cleaning Up Old PRs Tim, It took well over one year before anyone started looking at my August 2016 PR to implement VARDECIMAL decimal types improvements: https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_apache_drill_pull_570&d=DwIFAw&c=cskdkSMqhcnjZxdQVpwTXg&r=4eQVr8zB8ZBff-yxTimdOQ&m=MWi8kb0OAU2j5LMIUIewh8w-DPsI0o1XrKdc4X1s9d8&s=VRLzr69rpmak_g_UzdY7WYp-qS8QUnsHc7ySiWfzVFE&e= Volodymyr Vysotskyi ultimately grabbed the decimal types ball and ran with it, but I am concerned that my PR and some others would have gotten flushed prematurely with this kind of automatic cleaning regimen. Just my 2.5 cents. Dave Oshinsky ________________________________________ From: Timothy Farkas <[email protected]> Sent: Wednesday, June 6, 2018 6:12 PM To: [email protected] Subject: [Vote] Cleaning Up Old PRs The subject of this vote is whether / how to use probot stale. https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_probot_stale&d=DwIFAw&c=cskdkSMqhcnjZxdQVpwTXg&r=4eQVr8zB8ZBff-yxTimdOQ&m=MWi8kb0OAU2j5LMIUIewh8w-DPsI0o1XrKdc4X1s9d8&s=b-1khYEQPqc40pOYraMy-Dw3iGswgnIUXAkHE8YjGEw&e= Please fill out the survey below. https://urldefense.proofpoint.com/v2/url?u=https-3A__www.surveymonkey.com_r_NGDCX8R&d=DwIFAw&c=cskdkSMqhcnjZxdQVpwTXg&r=4eQVr8zB8ZBff-yxTimdOQ&m=MWi8kb0OAU2j5LMIUIewh8w-DPsI0o1XrKdc4X1s9d8&s=MNgiBpVkL2b8h4VWBYtgclKclzT2p1skDOOu-GeoWhk&e= If you feel this completely misses the mark of what should be done, please discuss on this thread. Also this is my first survey monkey poll, so if there are any issues please let me know. I'll follow up in two weeks to discuss the results. Thanks, Tim ***************************Legal Disclaimer*************************** "This communication may contain confidential and privileged material for the sole use of the intended recipient. Any unauthorized review, use or distribution by others is strictly prohibited. If you have received the message by mistake, please advise the sender by reply email and delete the message. Thank you." ********************************************************************** ***************************Legal Disclaimer*************************** "This communication may contain confidential and privileged material for the sole use of the intended recipient. Any unauthorized review, use or distribution by others is strictly prohibited. If you have received the message by mistake, please advise the sender by reply email and delete the message. Thank you." **********************************************************************
