vdiravka commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler URL: https://github.com/apache/drill/pull/1345#discussion_r199266170
########## File path: exec/java-exec/src/main/java/org/apache/drill/exec/store/StoragePluginRegistry.java ########## @@ -83,15 +84,13 @@ * @param name * @param plugin */ - void addPlugin(String name, StoragePlugin plugin); + void addPluginToEnabled(String name, StoragePlugin plugin); Review comment: It is not the same: this method adds one plugin to existing Map of enabled plugins. I suppose `addEnabledPlugin` looks good. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services