vdiravka commented on a change in pull request #1345: DRILL-6494: Drill Plugins
Handler
URL: https://github.com/apache/drill/pull/1345#discussion_r198928608
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/store/StoragePluginMap.java
##########
@@ -111,7 +112,7 @@ public StoragePlugin get(String name) {
return nameMap.entrySet().iterator();
}
- public Iterable<String> names() {
+ public Set<String> names() {
Review comment:
At least `Сollection` is needed for creating new Set from existing.
It is a requirement for plugins names, `Set` guarantees avoiding of
duplicates of names for plugins.
I have renamed it to `getNames()` and added javadoc
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
