vdiravka commented on a change in pull request #1337: Upgrade ZooKeeper patch
version to 3.4.12 and add Apache Curator to dependencyManagement
URL: https://github.com/apache/drill/pull/1337#discussion_r199457978
##########
File path: pom.xml
##########
@@ -257,6 +259,16 @@
<groupId>org.apache.curator</groupId>
<artifactId>curator-test</artifactId>
<version>${curator.test.version}</version>
+ <exclusions>
Review comment:
Could you place `<artifactId>curator-test</artifactId>` in the
dependencyManagement block too?
Also add `<version>`, `<scope>test</scope>`, ` <exclusions>` there and
remove it from all `<artifactId>curator-test</artifactId>` dependencies in
different modules.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
