vdiravka commented on a change in pull request #1337: Upgrade ZooKeeper patch
version to 3.4.12 and add Apache Curator to dependencyManagement
URL: https://github.com/apache/drill/pull/1337#discussion_r199470655
##########
File path: pom.xml
##########
@@ -1552,6 +1553,11 @@
</exclusion>
</exclusions>
</dependency>
+ <dependency>
+ <groupId>org.apache.zookeeper</groupId>
+ <artifactId>zookeeper</artifactId>
Review comment:
You have specified `Zookeeper` and `Curator` dependencies in
dependencyManagement block and it's fine. It is good for controlling the
versions of these libraries and their exclusions over the whole project.
But still this dependencies explicitly are used in the Drill project modules
as transitive dependencies. Could you specify them explicitly in dependencies
for Drill modules to avoid of using them as transitive dependencies?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
