vrozov commented on issue #1360: DRILL-6578: Handle query cancellation in 
Parquet reader
URL: https://github.com/apache/drill/pull/1360#issuecomment-402218679
 
 
   @sachouche If you prefer to throw `DrillRuntimeException`, make 
`checkInterrupted` a static method of `DrillRuntimeException`, but I would 
prefer to avoid throwing `DrillRuntimeException` in the iterator as the 
iterator does not know when to throw this exception. Instead, throw 
`InterrupedException` when the iterator is used in a loop.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to