vrozov commented on issue #1360: DRILL-6578: Handle query cancellation in Parquet reader URL: https://github.com/apache/drill/pull/1360#issuecomment-402286366 @sachouche I guess, you mean raise, not handle. For the rest a) if you throw DrillRuntimeException, please see c) b) yes (move it to a method that uses an iterator, if it is `setSafe()`, then move it to that method) c) I would prefer InterruptedException over DrillRuntimeException, but if it is too much to propagate InterruptedException, I am OK with DrillRuntimeException. d) yes, when an exception is raised, the interrupt flag needs to be cleared to avoid throwing exception again.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
