arina-ielchiieva commented on a change in pull request #1371: DRILL-6588: Make
Sys tables of nullable datatypes
URL: https://github.com/apache/drill/pull/1371#discussion_r201624058
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/store/RecordDataType.java
##########
@@ -47,17 +48,22 @@
* @return the constructed type
*/
public final RelDataType getRowType(RelDataTypeFactory factory) {
- final List<SqlTypeName> types = getFieldSqlTypeNames();
+ final List<ImmutablePair<SqlTypeName, Boolean>> types =
getFieldSqlTypeNames();
final List<String> names = getFieldNames();
final List<RelDataType> fields = Lists.newArrayList();
- for (final SqlTypeName typeName : types) {
+
+ for (ImmutablePair<SqlTypeName, Boolean> sqlTypePair : types) {
+ final SqlTypeName typeName = sqlTypePair.getLeft();
+ final RelDataType tmpRDT;
Review comment:
tmpRTD -> tmpDataType
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
