arina-ielchiieva commented on a change in pull request #1371: DRILL-6588: Make
Sys tables of nullable datatypes
URL: https://github.com/apache/drill/pull/1371#discussion_r201948032
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/store/RecordDataType.java
##########
@@ -47,17 +48,22 @@
* @return the constructed type
*/
public final RelDataType getRowType(RelDataTypeFactory factory) {
- final List<SqlTypeName> types = getFieldSqlTypeNames();
+ final List<ImmutablePair<SqlTypeName, Boolean>> types =
getFieldSqlTypeNames();
Review comment:
Ok, don't have strong opinion about this right now, so you may leave as is.
But I would prefer Java native implementation in this case:
```
AbstractMap.SimpleImmutableEntry<Integer, String> entry
= new AbstractMap.SimpleImmutableEntry<>(1, "one");
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
