vdiravka commented on a change in pull request #1372: DRILL-6589: Push 
transitive closure predicates past aggregates/projects
URL: https://github.com/apache/drill/pull/1372#discussion_r201647971
 
 

 ##########
 File path: 
exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/DrillPushFilterPastProjectRule.java
 ##########
 @@ -50,9 +54,12 @@
   }
 
   private DrillPushFilterPastProjectRule(RelBuilderFactory relBuilderFactory) {
-    super(operand(LogicalFilter.class, operand(LogicalProject.class, any())), 
relBuilderFactory,null);
+    super(operand(LogicalFilter.class, operand(LogicalProject.class, any())), 
relBuilderFactory, null);
   }
 
+  private DrillPushFilterPastProjectRule(RelBuilderFactory relBuilderFactory, 
boolean forDrill) {
 
 Review comment:
   Where forDrill is used? It is not necessary to create separate constructor 
with additional not used parameter for separate Instance.
   There is no need to use `LogicalFilter.class` and `LogicalProject.class` in 
original constructor. You can use `Filter.class` and `Project.class` instead.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to