vdiravka commented on a change in pull request #1372: DRILL-6589: Push 
transitive closure predicates past aggregates/projects
URL: https://github.com/apache/drill/pull/1372#discussion_r201651660
 
 

 ##########
 File path: 
exec/java-exec/src/test/java/org/apache/drill/exec/fn/impl/TestAggregateFunctions.java
 ##########
 @@ -732,6 +732,25 @@ public void testPushFilterInExprPastAgg() throws 
Exception {
         .build().run();
   }
 
+  @Test
+  public void testTransitiveFilterPushPastAgg() throws Exception {
 
 Review comment:
   This test case covers applying of `FilterAggregateTransposeRule`. Could you 
please add the test case for applying `DrillPushFilterPastProjectRule` after TC 
stage?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to