vvysotskyi commented on a change in pull request #1426: DRILL-6671: Multi level
lateral unnest join is throwing an exception …
URL: https://github.com/apache/drill/pull/1426#discussion_r208521406
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/physical/visitor/LateralUnnestRowIDVisitor.java
##########
@@ -64,7 +66,14 @@ public Prel visitLateral(LateralJoinPrel prel, Boolean
value) throws RuntimeExce
children.add(((Prel)prel.getInput(0)).accept(this, value));
children.add(((Prel) prel.getInput(1)).accept(this, true));
- return (Prel) prel.copy(prel.getTraitSet(), children);
+ if (!value) {
+ return (Prel) prel.copy(prel.getTraitSet(), children);
+ } else {
+ CorrelationId corrId = new CorrelationId(prel.getCorrelationId().getId()
+ 1);
+ ImmutableBitSet requiredColumns = prel.getRequiredColumns().shift(1);
Review comment:
Could you please add a comment that shift is required for taking into
account newly added `$drill_implicit_field$`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
