vvysotskyi commented on a change in pull request #1426: DRILL-6671: Multi level 
lateral unnest join is throwing an exception …
URL: https://github.com/apache/drill/pull/1426#discussion_r208515217
 
 

 ##########
 File path: 
exec/java-exec/src/main/java/org/apache/drill/exec/planner/physical/LateralJoinPrel.java
 ##########
 @@ -48,7 +48,7 @@
 public class LateralJoinPrel extends DrillLateralJoinRelBase implements Prel {
 
 
-  protected LateralJoinPrel(RelOptCluster cluster, RelTraitSet traits, RelNode 
left, RelNode right, boolean excludeCorrelateCol,
+  public LateralJoinPrel(RelOptCluster cluster, RelTraitSet traits, RelNode 
left, RelNode right, boolean excludeCorrelateCol,
 
 Review comment:
   I think there is no need to make this constructor public. In 
`LateralUnnestRowIDVisitor` may be used method `copy()` instead of using the 
constructor.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to