arina-ielchiieva commented on a change in pull request #1279: DRILL-5735: Allow search/sort in the Options webUI URL: https://github.com/apache/drill/pull/1279#discussion_r209918635
########## File path: exec/java-exec/src/main/resources/options.describe.properties ########## @@ -0,0 +1,107 @@ +# Review comment: Since we have now options.describe.properties file, how did we agree to enforce developers to add descriptions? Will project build fail if description was not added? Or maybe instead of using properties file, we can make `OptionValidator` to accept description along with option name, thus all options will be required to have description? And we won't have to duplicate options names in options.describe.properties? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
