arina-ielchiieva commented on a change in pull request #1279: DRILL-5735: Allow search/sort in the Options webUI URL: https://github.com/apache/drill/pull/1279#discussion_r210314954
########## File path: exec/java-exec/src/main/resources/options.describe.properties ########## @@ -0,0 +1,107 @@ +# Review comment: @kkhatua usually there is nothing more persistent then temporary :) Current list of options in properties files does not contain full list of system / session options. It means that the rest would have empty description, right? So I am not sure how this is better then updating OptionsValidators. Expanding the constructor and adding descriptions to options, does not seem to take a significant time, might be not the most interesting part of the development but still. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
