vvysotskyi commented on a change in pull request #1397: DRILL-6633: Replace
usage of Guava classes by JDK ones
URL: https://github.com/apache/drill/pull/1397#discussion_r210885040
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/xsort/ExternalSortBatch.java
##########
@@ -586,9 +587,9 @@ public BatchGroup mergeAndSpill(LinkedList<BatchGroup>
batchGroups) throws Schem
c1.setRecordCount(count);
String spillDir = dirs.next();
- Path currSpillPath = new Path(Joiner.on("/").join(spillDir, fileName));
+ Path currSpillPath = new Path(spillDir + "/" + fileName);
currSpillDirs.add(currSpillPath);
- String outputFile = Joiner.on("/").join(currSpillPath, spillCount++);
+ String outputFile = currSpillPath+ "/" + spillCount++;
Review comment:
`String.join()` requires only `CharSequence` arguments, but the last one is
`int`. Added space.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
