vvysotskyi commented on a change in pull request #1397: DRILL-6633: Replace
usage of Guava classes by JDK ones
URL: https://github.com/apache/drill/pull/1397#discussion_r212404433
##########
File path:
common/src/main/java/org/apache/drill/common/collections/ImmutableEntry.java
##########
@@ -17,11 +17,11 @@
*/
package org.apache.drill.common.collections;
-import java.util.Map;
-
-import com.google.common.base.Objects;
import com.google.common.base.Preconditions;
+import java.util.Map;
+import java.util.Objects;
+
public class ImmutableEntry<K, V> implements Map.Entry<K, V> {
Review comment:
The idea of replacing Guava classes appeared during the work on
https://github.com/apache/drill/pull/1264 and changes became larger than it was
expected initially.
The idea of replacing Drill custom classes is good, but it beyond the scope
of the current PR, so I think it would be better to address it in a separate
Jira.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
