vdiravka commented on a change in pull request #1397: DRILL-6633: Replace usage
of Guava classes by JDK ones
URL: https://github.com/apache/drill/pull/1397#discussion_r211228814
##########
File path:
contrib/storage-hive/core/src/test/java/org/apache/drill/exec/fn/hive/TestInbuiltHiveUDFs.java
##########
@@ -62,16 +62,16 @@ public void testEncode() throws Exception {
@Test
public void testXpath_Double() throws Exception {
- final String query = "select xpath_double ('<a><b>20</b><c>40</c></a>',
'a/b * a/c') as col \n" +
+ String query = "select xpath_double ('<a><b>20</b><c>40</c></a>', 'a/b *
a/c') as col \n" +
"from hive.kv \n" +
Review comment:
The `limit 0` is used for getting schema only, the purpose of test is to
verify `xpath_double` UDF.
It is not SQL formatting style even.
But I will not argue, since it is minor and not your code. I will let you to
make the final decision
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
