vdiravka commented on a change in pull request #1397: DRILL-6633: Replace usage
of Guava classes by JDK ones
URL: https://github.com/apache/drill/pull/1397#discussion_r211243271
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/server/options/TypeValidators.java
##########
@@ -242,7 +241,7 @@ public String getAdminUserGroups(OptionManager
optionManager) {
// if this option has not been changed by the user then return the
// process user groups
if (adminUserGroups.equals(DEFAULT_ADMIN_USER_GROUPS)) {
- adminUserGroups =
Joiner.on(",").join(ImpersonationUtil.getProcessUserGroupNames());
+ adminUserGroups = String.join(",",
ImpersonationUtil.getProcessUserGroupNames());
Review comment:
It depends on where `adminUserGroups` is used.
Ok, let's leave it as is
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
